test(contracts): improve unit and e2e gas pump tests #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
force-pushed
the
kh/better-gaspump-tests
branch
from
9846c18
to
03bdedb
Compare
kevinhalliday
requested review from
corverroos,
arajasek,
brid and
ttarsi
as code owners
kevinhalliday
force-pushed
the
kh/better-gaspump-tests
branch
from
03bdedb
to
7661ae0
Compare
kevinhalliday
commented
Sep 5, 2024
| @@ -161,7 +163,7 @@ contract OmniGasPump is XAppUpgradeable, OwnableUpgradeable, PausableUpgradeable | |||
| uint256 amtETH = _toEth(amtOMNI); | |||
|
|
|||
| // "undo" toll | |||
| amtETH += (amtETH * TOLL_DENOM / (TOLL_DENOM - toll)); | |||
| amtETH = (amtETH * TOLL_DENOM / (TOLL_DENOM - toll)); | |||
kevinhalliday
force-pushed
the
kh/better-gaspump-tests
branch
from
7661ae0
to
e92851e
Compare
ttarsi
approved these changes
Sep 5, 2024
| @@ -161,7 +163,7 @@ contract OmniGasPump is XAppUpgradeable, OwnableUpgradeable, PausableUpgradeable | |||
| uint256 amtETH = _toEth(amtOMNI); | |||
|
|
|||
| // "undo" toll | |||
| amtETH += (amtETH * TOLL_DENOM / (TOLL_DENOM - toll)); | |||
| amtETH = (amtETH * TOLL_DENOM / (TOLL_DENOM - toll)); | |||
|
|
||
| // assert quoted and actual within 10 wei of each other | ||
| // allows for rounding errors in different between taking / undoing toll | ||
| _assertWithinEpisilon(dryRunOMNI, targetOMNI, 10); |
There was a problem hiding this comment.
Suggested change
| _assertWithinEpisilon(dryRunOMNI, targetOMNI, 10); | |
| _assertWithinEpsilon(dryRunOMNI, targetOMNI, 10); |
kevinhalliday
force-pushed
the
kh/better-gaspump-tests
branch
from
e92851e
to
b26e494
Compare
Improve unit and e2e gas pump tests. Fix bug in OmniGasPump.quote()
kevinhalliday
force-pushed
the
kh/better-gaspump-tests
branch
from
b26e494
to
8f7a480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve unit and e2e gas pump tests.
Additional:
issue: #1686